Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prognostic cumulus closure description in saSAS #1187

Merged
merged 90 commits into from
Jun 3, 2022

Conversation

lisa-bengtsson
Copy link
Contributor

@lisa-bengtsson lisa-bengtsson commented Apr 20, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

This PR introduces an optional closure assumption to the Arakawa-Schubert cloud work function in saSAS cumulus convection, in where the mass-flux at cloud base is described as the product between updraft area fraction and updraft velocity. The updraft area fraction is given by a prognostic moisture budget equation.

The update is not aimed for UFS coupled prototype 8, but is an option to be explored beyond P8.

In addition to updates in the ccpp/physics submodule, new field_table, and namelist parameters are added in ufs-weather-model.

The PR is also making a small change in the stochastic_physics_driver.F90 to allow the cellular automata to work on non-uniform blocksizes. Previously the code aborted if not all blocks in the domain had the same size, however, the code works the way it's been formulated, so I simply removed the call to mpp_error in case on non-uniform blocksizes.

##Testing

This PR does not change the answers in the control, but a new test has been added where the scheme is activated using progsigma = True.

The regression tests have been tested on Hera.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • wcoss2
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

Issue: NCAR/ccpp-physics#890
#1193

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
[RT] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/913741286/20220602174517/ufs-weather-model
[RT] Error: Test control_c192 017 failed in run_test failed
Please make changes and add the following label back: jet-intel-RT

@jkbk2004 jkbk2004 added the run-ci label Jun 2, 2022
@github-actions github-actions bot removed the run-ci label Jun 2, 2022
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jun 2, 2022

@DeniseWorthen @MinsukJi-NOAA @junwang-noaa @grantfirl RT passes ok! CI is running. Can you leave review comments?

@grantfirl
Copy link
Collaborator

@jkbk2004 @junwang-noaa I'm at a conference today, but I can start the merge process when ready if before 12 ET. After 12 ET, I'll be traveling home for the remainder of the afternoon. If necessary, I can also delegate this to someone else.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jun 3, 2022

@grantfirl can we start merging in ccpp#903 and then fv3atm#523 ?

@grantfirl
Copy link
Collaborator

@grantfirl can we start merging in ccpp#903 and then fv3atm#523 ?

I've merged NCAR/ccpp-physics#903 and instructed @lisa-bengtsson to make the changes to her fv3atm branch in anticipation of the merge.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jun 3, 2022

@lisa-bengtsson can you revert the fv3atm pointer here as well? so we can merge in.

@lisa-bengtsson
Copy link
Contributor Author

@jkbk2004 I updated the .gitmodules and FV3

@jkbk2004 jkbk2004 merged commit a86d5a2 into ufs-community:develop Jun 3, 2022
@lisa-bengtsson
Copy link
Contributor Author

Thank you all for all the work on running RT's and merging this!

bluefinweiwei added a commit to bluefinweiwei/ufs-weather-model that referenced this pull request Oct 12, 2022
…fs-community#1187"

https://github.com/ufs-community/ufs-weather-model/pull/1187/files
	modified:   FV3
	modified:   tests/default_vars.sh
	modified:   tests/opnReqTests/dcp.sh
	modified:   tests/parm/control.nml.IN
	new file:   tests/parm/field_table/field_table_gfsv16_progsigma
bluefinweiwei added a commit to DTC-phytne/ufs-weather-model that referenced this pull request Oct 13, 2022
…fs-community#1187" (#1)

https://github.com/ufs-community/ufs-weather-model/pull/1187/files
	modified:   FV3
	modified:   tests/default_vars.sh
	modified:   tests/opnReqTests/dcp.sh
	modified:   tests/parm/control.nml.IN
	new file:   tests/parm/field_table/field_table_gfsv16_progsigma
bluefinweiwei added a commit to DTC-phytne/ufs-weather-model that referenced this pull request Oct 13, 2022
* Adopt progsigma "Add prognostic cumulus closure description in saSAS ufs-community#1187"
https://github.com/ufs-community/ufs-weather-model/pull/1187/files
	modified:   FV3
	modified:   tests/default_vars.sh
	modified:   tests/opnReqTests/dcp.sh
	modified:   tests/parm/control.nml.IN
	new file:   tests/parm/field_table/field_table_gfsv16_progsigma

* modified:   .gitmodules
bluefinweiwei added a commit to DTC-phytne/ufs-weather-model that referenced this pull request Oct 13, 2022
* Adopt progsigma "Add prognostic cumulus closure description in saSAS ufs-community#1187"
https://github.com/ufs-community/ufs-weather-model/pull/1187/files
	modified:   FV3
	modified:   tests/default_vars.sh
	modified:   tests/opnReqTests/dcp.sh
	modified:   tests/parm/control.nml.IN
	new file:   tests/parm/field_table/field_table_gfsv16_progsigma

* modified:   .gitmodules

	modified:   .gitmodules
bluefinweiwei added a commit to DTC-phytne/ufs-weather-model that referenced this pull request Oct 13, 2022
* Adopt progsigma "Add prognostic cumulus closure description in saSAS ufs-community#1187"
https://github.com/ufs-community/ufs-weather-model/pull/1187/files
	modified:   FV3
	modified:   tests/default_vars.sh
	modified:   tests/opnReqTests/dcp.sh
	modified:   tests/parm/control.nml.IN
	new file:   tests/parm/field_table/field_table_gfsv16_progsigma

* modified:   .gitmodules

	modified:   .gitmodules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants